Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
38dbdab to
f0b9359
Compare
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
8cf6c99 to
c477e0e
Compare
rytaft
left a comment
There was a problem hiding this comment.
Looks great! Thanks for all this work! Just a few comments.
2fbb646 to
6ece21c
Compare
|
@rytaft TFTR and sorry I took a while to get back to this! I revised per your feedback; could you please have another look? |
florence-crl
left a comment
There was a problem hiding this comment.
LGTM pending suggestions.
Please apply suggestions from earlier versions to later versions as applicable.
In v25.4, should the CREATE STATISTICS syntax include WHERE?
| | `sql_stats_automatic_collection_enabled` | Enable automatic collection of [full]({% link {{ page.version.version }}/cost-based-optimizer.md %}#full-statistics) and [partial]({% link {{ page.version.version }}/cost-based-optimizer.md %}#partial-statistics) statistics for this table. | Boolean | `true` | | ||
| | `sql_stats_automatic_collection_min_stale_rows` | Minimum number of stale rows in this table that will trigger a full statistics refresh. | Integer | 500 | | ||
| | `sql_stats_automatic_collection_fraction_stale_rows` | Fraction of stale rows in this table that will trigger a full statistics refresh. | Float | 0.2 | | ||
| | `sql_stats_automatic_full_collection_enabled` | {% include_cached new-in.html version="v25.2" %} Enable automatic collection of [full statistics]({% link {{ page.version.version }}/cost-based-optimizer.md %}#full-statistics) for this table. | Boolean | `true` | |
There was a problem hiding this comment.
Using {% include_cached new-in.html version="v25.2" %} in a table does not render properly. See in:
https://deploy-preview-22087--cockroachdb-docs.netlify.app/docs/v25.2/with-storage-parameter#table-parame
| | `sql_stats_automatic_collection_enabled` | Enable automatic collection of [full]({% link {{ page.version.version }}/cost-based-optimizer.md %}#full-statistics) and [partial]({% link {{ page.version.version }}/cost-based-optimizer.md %}#partial-statistics) statistics for this table. | Boolean | `true` | | ||
| | `sql_stats_automatic_collection_min_stale_rows` | Minimum number of stale rows in this table that will trigger a full statistics refresh. | Integer | 500 | | ||
| | `sql_stats_automatic_collection_fraction_stale_rows` | Fraction of stale rows in this table that will trigger a full statistics refresh. | Float | 0.2 | | ||
| | `sql_stats_forecasts_enabled` | Enable [forecasted statistics]({% link {{ page.version.version }}/show-statistics.md %}#display-forecasted-statistics) collection for this table. | Boolean | `true` | |
There was a problem hiding this comment.
please put this row in alphabetical order.
387721f to
6fa129f
Compare
DOC-14809
DOC-11635
DOC-10969
DOC-10915
DOC-12760
Improve our partial statistics docs as follows:
CREATE STATISTICSpageThese updates apply to 23.2-26.1, according to the following feature timeline (please call out if incorrect):
enable_create_stats_using_extremes= off (session)USING EXTREMESenabled by defaultenable_create_stats_using_extremes= on (session);optimizer_use_merged_partial_statistics= off (session)sql.stats.automatic_partial_collection.enabled= true;sql.stats.automatic_partial_collection.min_stale_rows= 100;sql.stats.automatic_partial_collection.fraction_stale_rows= 0.05; table-level equivalentsoptimizer_use_merged_partial_statistics= on;sql.stats.automatic_partial_collection.enabled= true;sql.stats.automatic_full_collection.enabled= true; table-level equivalentsWHERE)WHEREDocs to review (v26.1; please use the version dropdown menu to change versions):
CREATE STATISTICS